Skip to content

Conversation

@SC-One
Copy link

@SC-One SC-One commented Apr 30, 2024

Closes #12

Evidences

TODO

@GuillaumeFalourd
Copy link
Owner

GuillaumeFalourd commented Apr 30, 2024

Hi @SC-One ! Thank you for contributing 👍🏼

Could you please follow the contribution guidelines and make sure you tested your implementation for each OS runner with GHA workflows on your fork? (you could then share your evidences in the PR description above)

More over, I observed you added an input that will change the current behavior. To avoid breaking changes, I would suggest adding a new if [ "${{ inputs.third-user }}" = "true" ]; then condition and perform the git clone command using https://${{ inputs.third-user }}:${{ inputs.access-token }} only in that case.

Does ii make sense?

@GuillaumeFalourd GuillaumeFalourd added enhancement New feature or request Waiting for return Waiting for return labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Waiting for return Waiting for return

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clone with member of the repo[not owner]

2 participants